Skip to content

Add crop region #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rob1in merged 6 commits into from
Apr 25, 2025
Merged

Add crop region #43

Rob1in merged 6 commits into from
Apr 25, 2025

Conversation

@Rob1in
Copy link
Contributor

@Rob1in Rob1in commented Apr 23, 2025 •
edited
Loading

Goal:
Adding a new config attribute called:crop_region.
Usage:
Something like:

  "crop_region": {
    "x2_rel": 1,
    "y2_rel": 1,
    "x1_rel": 0.5,
    "y1_rel": 0.5
  }

We can go over the PR together since my IDE did a lot of linting on save and it's hard to review.

@Rob1in Rob1in requested a review from kharijarrett April 23, 2025 18:11
kharijarrett
kharijarrett approved these changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@kharijarrett kharijarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Rob1in Rob1in merged commit fb21461 into viam-modules:main Apr 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kharijarrett kharijarrett kharijarrett approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rob1in @kharijarrett